Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35267 )
Change subject: soc/amd/common: Add missing stdint.h to BiosCallOuts.h ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35267/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35267/1//COMMIT_MSG@8 PS1, Line 8:
Please declare why it's needed.
Done
https://review.coreboot.org/c/coreboot/+/35267/2/src/soc/amd/common/block/in... File src/soc/amd/common/block/include/amdblocks/BiosCallOuts.h:
https://review.coreboot.org/c/coreboot/+/35267/2/src/soc/amd/common/block/in... PS2, Line 21: #include <stdint.h>
amdblocks/agesawrapper.h already include stdint. […]
AFAIK we try to overtly add includes to files using a definition, typedef, etc. vs. relying on them being layered.