Attention is currently required from: Anil Kumar K, Tarun Tuli, Subrata Banik, Kapil Porwal, Sridhar Siricilla.
Anil Kumar K has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74763 )
Change subject: soc/intel/meteorlake: Add config option to choose CSE FW sync in ROMSTAGE
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/meteorlake/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/74763/comment/0c3d44bc_876b365c
PS1, Line 130:
: if (!s3wake && CONFIG(SOC_INTEL_CSE_LITE_SYNC_IN_ROMSTAGE))
: cse_fw_sync();
cse_fw_sync is not required here as you are implementing cse_fw_sync() in ramstage.
this gives the option to mainboard to choose - ROMSTAGE or RAMSTAGE depending on the config flag
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74763
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8e603a2ecf1a67ee7c683b440072889d137f9de0
Gerrit-Change-Number: 74763
Gerrit-PatchSet: 1
Gerrit-Owner: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anil Kumar K
anil.kumar.k@intel.corp-partner.google.com
Gerrit-CC: Bora Guvendik
bora.guvendik@intel.com
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-CC: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-CC: Jeremy Compostella
jeremy.compostella@gmail.com
Gerrit-CC: Rizwan Qureshi
riz.pro@gmail.com
Gerrit-CC: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Comment-Date: Wed, 26 Apr 2023 05:12:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-MessageType: comment