Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37935 )
Change subject: src/*.asl: Remove _HID / _ADR objects
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/37935/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/37935/5//COMMIT_MSG@9
PS5, Line 9: A device object must contain either a _HID object or an _ADR object, but should not contain both. _HID objects are enumerated and have their drivers loaded by ACPI, whereas _ADR objects typically perform most functions without involving ACPI.
Please break lines before 72 chars. I'm also not sure about the
last part: _ADR links the ASL node to the OS-enumerated device,
that's all. It doesn't imply anything about what the ASL code does
with the device.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37935
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I949393558f5af66689c167b2e593a1461f641962
Gerrit-Change-Number: 37935
Gerrit-PatchSet: 5
Gerrit-Owner: Jonas Moehle
ad-min@mailbox.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Jonas Moehle
ad-min@mailbox.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Comment-Date: Wed, 01 Jan 2020 19:58:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment