Chris Zhou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31062 )
Change subject: mb/google/sarien/variants/sarien: Using HID over I2C to enable Melf TouchScreen
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31062/1/src/mainboard/google/sarien/variants...
File src/mainboard/google/sarien/variants/sarien/devicetree.cb:
https://review.coreboot.org/#/c/31062/1/src/mainboard/google/sarien/variants...
PS1, Line 229: register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E7)"
More than 80?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31062
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If04a2904a0f72a6c8363ab2c9865926c71cb5186
Gerrit-Change-Number: 31062
Gerrit-PatchSet: 2
Gerrit-Owner: Chris Zhou
chris_zhou@compal.corp-partner.google.com
Gerrit-Reviewer: Chris Zhou
chris_zhou@compal.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-CC: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Comment-Date: Fri, 25 Jan 2019 05:53:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Lijian Zhao
lijian.zhao@intel.com
Gerrit-MessageType: comment