Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29968 )
Change subject: qcs405: Add blsp spi driver and enable SPI-NOR
......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/#/c/29968/9/src/soc/qualcomm/qcs405/spi.c
File src/soc/qualcomm/qcs405/spi.c:
https://review.coreboot.org/#/c/29968/9/src/soc/qualcomm/qcs405/spi.c@512
PS9, Line 512: unsigned int read_len = 3; //bytes; hack for now
That looks incomplete. Might that be related to the issues we see when communicating with the TPM?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29968
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I340eb3bf77b25fe3502d4b29ef4bf7c06b282c02
Gerrit-Change-Number: 29968
Gerrit-PatchSet: 9
Gerrit-Owner: nsekar@codeaurora.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: nsekar@codeaurora.org
Gerrit-Comment-Date: Tue, 22 Jan 2019 17:06:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment