Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40612 )
Change subject: soc/intel/jasperlake: Enable end of post support ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40612/1/src/soc/intel/jasperlake/fs... File src/soc/intel/jasperlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/40612/1/src/soc/intel/jasperlake/fs... PS1, Line 101: EndOfPostMessage
also isn't EOP is mandatory and why do we have to set such UPDs which is silicon recommended setting […]
Current dsc default(value: 2) is set for DXE(not to disable). Need to set it to PEI(value : 1) for EOP routine to be executed under FSP notify.
https://review.coreboot.org/c/coreboot/+/40612/1/src/soc/intel/jasperlake/fs... PS1, Line 101: 0x01
So, what is the difference between sending EOP in PEI v/s DXE? I believe this is setting it to happe […]
Yes, this is issue EOP in PEI phase. The DXE EOP implementation does not apply for coreboot. rather is used by UEFI bootloader. This configuration ensures the EOP routine is called in FSP Notify phase.