Keith Tzeng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45756 )
Change subject: mb/google/zork: de-assert eMMC RST for Morphius
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45756/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45756/1//COMMIT_MSG@11
PS1, Line 11: 169211959
Did you mean: 169222156?
Should be b:169222156
https://review.coreboot.org/c/coreboot/+/45756/1//COMMIT_MSG@14
PS1, Line 14: check GPIO86 state is PU
What is the difference from a functional standpoint? Are you seeing some error go away because of th […]
as on tracker: https://partnerissuetracker.corp.google.com/issues/169222156#comment7
the reset pin keep low on your measurement, eMMC vendor feedback that it need to be high.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45756
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9feb826eec8a8cdad5e2bd7efcbb1dcf96185dfd
Gerrit-Change-Number: 45756
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Keith Tzeng
keith.tzeng@quanta.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 26 Sep 2020 14:15:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment