John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44501 )
Change subject: mb/google/volteer: Configure DP_HPD as PAD_NC and disable DdiPortHpd
......................................................................
Patch Set 5:
(1 comment)
Patch Set 2:
Native function pin mux for DPs are done by FSP after pin mux by gpio.c
So, we also need to configure below in overridetree.cb for not confuring DP_HPD1 and DP_HPD2.
register "DdiPort1Hpd" = "0"
register "DdiPort2Hpd" = "0"
Note that these are enabled in devicetree.cb in baseboard.
https://review.coreboot.org/c/coreboot/+/44501/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/44501/4//COMMIT_MSG@17
PS4, Line 17: Voteer
Volteer 😉
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44501
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia3245741b776b75073d2b43d36c8ea40b476b3ed
Gerrit-Change-Number: 44501
Gerrit-PatchSet: 5
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Chiranjeevi Rapolu
chiranjeevi.rapolu@intel.corp-partner.google.com
Gerrit-Reviewer: Eric Herrmann
eherrmann@chromium.org
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 17 Aug 2020 19:54:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment