build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31591 )
Change subject: mediaek/mt8183: add dsi driver for mt8183 ......................................................................
Patch Set 4:
(8 comments)
https://review.coreboot.org/#/c/31591/4/src/soc/mediatek/mt8183/dsi.c File src/soc/mediatek/mt8183/dsi.c:
https://review.coreboot.org/#/c/31591/4/src/soc/mediatek/mt8183/dsi.c@28 PS4, Line 28: static void mipi_clrsetbits_le32(void *a, uint32_t offset, uint32_t m, uint32_t v) line over 80 characters
https://review.coreboot.org/#/c/31591/4/src/soc/mediatek/mt8183/dsi.c@64 PS4, Line 64: const struct edid *edid, struct mtk_phy_timing *phy_timing) line over 80 characters
https://review.coreboot.org/#/c/31591/4/src/soc/mediatek/mt8183/dsi.c@96 PS4, Line 96: data_rate = (u64)(edid->mode.pixel_clock * 1000 * total_bits) / (htotal * lanes); line over 80 characters
https://review.coreboot.org/#/c/31591/4/src/soc/mediatek/mt8183/dsi.c@133 PS4, Line 133: pcw = (u64)((data_rate / 1000000) * (1 << txdiv0) * (1 << txdiv1)) << 24; line over 80 characters
https://review.coreboot.org/#/c/31591/4/src/soc/mediatek/mt8183/dsi.c@159 PS4, Line 159: static void mtk_dsi_phy_timconfig(u32 data_rate, struct mtk_phy_timing *phy_timing) line over 80 characters
https://review.coreboot.org/#/c/31591/4/src/soc/mediatek/mt8183/dsi.c@212 PS4, Line 212: const struct edid *edid, struct mtk_phy_timing *phy_timing) line over 80 characters
https://review.coreboot.org/#/c/31591/4/src/soc/mediatek/mt8183/dsi.c@444 PS4, Line 444: const struct edid *edid, struct lcm_init_table *init_cmd, u32 count) line over 80 characters
https://review.coreboot.org/#/c/31591/4/src/soc/mediatek/mt8183/include/soc/... File src/soc/mediatek/mt8183/include/soc/dsi.h:
https://review.coreboot.org/#/c/31591/4/src/soc/mediatek/mt8183/include/soc/... PS4, Line 482: const struct edid *edid, struct lcm_init_table *init_cmd, u32 count); line over 80 characters