Attention is currently required from: Tim Wawrzynczak. Tarun Tuli has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/63984 )
Change subject: soc/intel/alderlake: add missing ACPI device path names ......................................................................
soc/intel/alderlake: add missing ACPI device path names
A few ACPI device path name handlers are missing. Add handling to ensure that these names are returned during acpi_device_path() calls.
TEST=Built and tested on brya
Signed-off-by: Tarun Tuli taruntuli@google.com Change-Id: I37d6dd5df921c931af72dd469c3f4067c61b0df3 --- M src/soc/intel/alderlake/chip.c M src/soc/intel/common/block/uart/uart.c 2 files changed, 8 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/63984/1
diff --git a/src/soc/intel/alderlake/chip.c b/src/soc/intel/alderlake/chip.c index 699b39d..59f0066 100644 --- a/src/soc/intel/alderlake/chip.c +++ b/src/soc/intel/alderlake/chip.c @@ -75,6 +75,7 @@ case SA_DEVFN_TBT2: return "TRP2"; case SA_DEVFN_TBT3: return "TRP3"; case SA_DEVFN_IPU: return "IPU0"; + case SA_DEVFN_DPTF: return "DPTF"; case PCH_DEVFN_ISH: return "ISHB"; case PCH_DEVFN_XHCI: return "XHCI"; case PCH_DEVFN_I2C0: return "I2C0"; @@ -111,6 +112,9 @@ case PCH_DEVFN_HDA: return "HDAS"; case PCH_DEVFN_SMBUS: return "SBUS"; case PCH_DEVFN_GBE: return "GLAN"; + case PCH_DEVFN_SRAM: return "SRAM"; + case PCH_DEVFN_SPI: return "FSPI"; + case PCH_DEVFN_CSE: return "HEC1"; #if CONFIG(SOC_INTEL_ALDERLAKE_PCH_N) case PCH_DEVFN_EMMC: return "EMMC"; #endif diff --git a/src/soc/intel/common/block/uart/uart.c b/src/soc/intel/common/block/uart/uart.c index 12f2882..3e2e697 100644 --- a/src/soc/intel/common/block/uart/uart.c +++ b/src/soc/intel/common/block/uart/uart.c @@ -308,24 +308,28 @@ static const char *uart_acpi_name(const struct device *dev) { switch (dev->device) { + case PCI_DID_INTEL_ADP_P_UART0: case PCI_DID_INTEL_APL_UART0: case PCI_DID_INTEL_GLK_UART0: case PCI_DID_INTEL_SPT_UART0: case PCI_DID_INTEL_SPT_H_UART0: case PCI_DID_INTEL_CNP_H_UART0: return "UAR0"; + case PCI_DID_INTEL_ADP_P_UART1: case PCI_DID_INTEL_APL_UART1: case PCI_DID_INTEL_GLK_UART1: case PCI_DID_INTEL_SPT_UART1: case PCI_DID_INTEL_SPT_H_UART1: case PCI_DID_INTEL_CNP_H_UART1: return "UAR1"; + case PCI_DID_INTEL_ADP_P_UART2: case PCI_DID_INTEL_APL_UART2: case PCI_DID_INTEL_GLK_UART2: case PCI_DID_INTEL_SPT_UART2: case PCI_DID_INTEL_SPT_H_UART2: case PCI_DID_INTEL_CNP_H_UART2: return "UAR2"; + case PCI_DID_INTEL_ADP_P_UART3: case PCI_DID_INTEL_GLK_UART3: return "UAR3"; default: