Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34180 )
Change subject: mb/google/hatch: Enable/disable GPIO clock gating ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34180/3/src/mainboard/google/hatch/... File src/mainboard/google/hatch/mainboard.asl:
https://review.coreboot.org/c/coreboot/+/34180/3/src/mainboard/google/hatch/... PS3, Line 25: CGPM Why not add this method to soc/intel/cannonlake? It can take as parameter the value of PM config that needs to be set.