Attention is currently required from: Furquan Shaikh, Werner Zeh, Aaron Durbin, Patrick Rudolph.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51631 )
Change subject: [WIP] soc/intel/braswell: Use SOC_INTEL_COMMON_BLOCK_I2C
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/braswell/acpi/lpss.asl:
https://review.coreboot.org/c/coreboot/+/51631/comment/66a7c8ac_fa5d714d
PS1, Line 104: /* Standard Mode: HCNT, LCNT, SDA Hold Time */
: Name (SSCN, Package () { 0x200, 0x200, BOARD_I2C1_DATA_HOLD_TIME })
:
: /* Fast Mode: HCNT, LCNT, SDA Hold Time */
: Name (FMCN, Package () { 0x55, 0x99, BOARD_I2C1_DATA_HOLD_TIME })
I have no clue weather there is a dependency to this inside the OS. […]
Yes, someone with hardware access should take action to make this move forwards.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51631
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2d74a887f6b478fec7ff210fbc6b7da17b862b1c
Gerrit-Change-Number: 51631
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Aaron Durbin
adurbin@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 28 Apr 2021 05:31:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Gerrit-MessageType: comment