29 Nov
2019
29 Nov
'19
3:40 a.m.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37054 )
Change subject: arch/*/*/early_variables.h: drop unused files ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37054/7/src/commonlib/include/commo... File src/commonlib/include/commonlib/cbmem_id.h:
https://review.coreboot.org/c/coreboot/+/37054/7/src/commonlib/include/commo... PS7, Line 23: #define CBMEM_ID_CAR_GLOBALS 0xcac4e6a3 I think the data here (and the table below) are used by the cbmem utility. Do we want it to know about the CAR globals for longer? (Scenario: cbmem from master used on an old coreboot)
--
To view, visit https://review.coreboot.org/c/coreboot/+/37054
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieb7d9f5590b3a7dd1fd5c0ce2e51337332434dbd
Gerrit-Change-Number: 37054
Gerrit-PatchSet: 7
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Philipp Hug philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: ron minnich rminnich@gmail.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 29 Nov 2019 11:40:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment