[coreboot-gerrit] [S] Change in coreboot[master]: acpi: Add a runtime method to override exposed _Sx sleep states

[Arthur Heymans (Code Review)]

Attention is currently required from: Lance Zhao, Nico Huber, Paul Menzel, Tim Wawrzynczak, Maximilian Brune, Lean Sheng Tan, Werner Zeh, Jan Samek.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74762 )

Change subject: acpi: Add a runtime method to override exposed _Sx sleep states
......................................................................

Patch Set 7:

(2 comments)

File src/acpi/Kconfig:

https://review.coreboot.org/c/coreboot/+/74762/comment/4c7b91e2_649bbf93 
PS4, Line 65: config OVERRIDE_ENABLED_SLEEP_STATES
> What’s the downside of always disallowing it?

What do you mean?

File src/acpi/acpi.c:

https://review.coreboot.org/c/coreboot/+/74762/comment/4e30a7a5_d70fc7f5 
PS4, Line 528: (enable_s1 << 0) | (enable_s2 << 1)
             : 		| (enable_s3 << 2) | (enable_s4 << 3)
> maybe bitshifting 'bool' isn't the best idea...

Done