Attention is currently required from: Ana Carolina Cabral, Anand Vaikar, Bao Zheng, Felix Held.
Maximilian Brune has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/84373?usp=email )
Change subject: util/amdfwtool: Add binaries
......................................................................
Patch Set 6:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84373/comment/c1536f0e_b83f4aee?usp... :
PS5, Line 7: util/amdfwtool: Add binaries
Please detail
Sadly this is as much as I can give.
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/84373/comment/8c69b9a9_10c98415?usp... :
PS4, Line 374: BDT_BOTH
I don't know the right answer either. What do you think how we should proceed? […]
I will just keep it as it is, since ucode is updated via coreboot anyway.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84373?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I78d7a9dba71de557e0a9a885d8561eea1f4191ef
Gerrit-Change-Number: 84373
Gerrit-PatchSet: 6
Gerrit-Owner: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Anand Vaikar
a.vaikar2021@gmail.com
Gerrit-Reviewer: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ana Carolina Cabral
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Anand Vaikar
a.vaikar2021@gmail.com
Gerrit-Attention: Ana Carolina Cabral
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 11 Nov 2024 16:14:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maximilian Brune
maximilian.brune@9elements.com
Comment-In-Reply-To: Ana Carolina Cabral
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de