Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46880 )
Change subject: soc/intel/common/block/cse: Add MCHI MCA group functions to cse lib ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46880/1/src/soc/intel/common/block/... File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/46880/1/src/soc/intel/common/block/... PS1, Line 53: MCA_COMMIT_FILES 0x04
I prefer to do it along with CSE FW Sync and avoid resetting multiple times in boot flow.
This operation can only be done when CSE is booting from RW 1. The Set File and Commit file commands are not supported in RO because the MCHI client is only part of CE-RW 2. The Data files created in this operation are part of the RW data region which is deployed only when CSE boots from RW
In order to avoid an extra reset we can make the DAM disabling as part of cse_fw_sync, like below 1. In cse_fw_sync 2. Check if CSE is booted from RO 2.1 if CSE not in RO set next BP to RW 2.2 Check if DAM disable is required by checking board SKU 2.3 if DAM change required then trigger a CSE only reset 2.4 Wait for CSE to boot into RW 2.5 Run Set file and commit file 3. Do global reset
This flow needs to be confirmed, will update if this works