Srinidhi N Kaushik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47991 )
Change subject: soc/intel/common/fast_spi: Add support for configuring MTRRs
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47991/1/src/soc/intel/common/block/...
File src/soc/intel/common/block/fast_spi/fast_spi.c:
https://review.coreboot.org/c/coreboot/+/47991/1/src/soc/intel/common/block/...
PS1, Line 238: if (ENV_PAYLOAD_LOADER) {
: mtrr_use_temp_range(ext_bios_base, ext_bios_size, type);
: } else {
: int mtrr = get_free_var_mtrr();
:
: if (mtrr == -1)
: return;
:
: set_var_mtrr(mtrr, ext_bios_base, ext_bios_size, type);
: }
Yes, the flow will have to be: […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47991
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9711f110a35a167efe3a4c912cf46c63c0812779
Gerrit-Change-Number: 47991
Gerrit-PatchSet: 3
Gerrit-Owner: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 26 Nov 2020 06:10:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-MessageType: comment