Attention is currently required from: Martin Roth, Michał Żygowski, Marshall Dawson, Subrata Banik, Andrey Petrov, Patrick Rudolph, Nathaniel L Desimone. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56190 )
Change subject: src/drivers/intel/fsp2_0: allow larger FSP 2.0 header ......................................................................
Patch Set 4:
(16 comments)
File src/drivers/intel/fsp2_0/util.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124091): https://review.coreboot.org/c/coreboot/+/56190/comment/d42656b6_bb2451ab PS4, Line 17: if (CONFIG(PLATFORM_USES_FSP2_2)) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124091): https://review.coreboot.org/c/coreboot/+/56190/comment/e6b95164_6817d412 PS4, Line 17: if (CONFIG(PLATFORM_USES_FSP2_2)) suspect code indent for conditional statements (5, 10)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124091): https://review.coreboot.org/c/coreboot/+/56190/comment/5036e9c8_01729dc8 PS4, Line 18: return 76; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124091): https://review.coreboot.org/c/coreboot/+/56190/comment/1caef222_b36a6ad5 PS4, Line 18: return 76; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124091): https://review.coreboot.org/c/coreboot/+/56190/comment/0ff6b7b6_3cbff0a6 PS4, Line 19: else if (CONFIG(PLATFORM_USES_FSP2_1)) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124091): https://review.coreboot.org/c/coreboot/+/56190/comment/01fdb559_6757652f PS4, Line 19: else if (CONFIG(PLATFORM_USES_FSP2_1)) suspect code indent for conditional statements (5, 10)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124091): https://review.coreboot.org/c/coreboot/+/56190/comment/e4406f98_16fcc28e PS4, Line 20: return 72; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124091): https://review.coreboot.org/c/coreboot/+/56190/comment/7bca3221_b31f2e13 PS4, Line 20: return 72; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124091): https://review.coreboot.org/c/coreboot/+/56190/comment/5f383b35_b1bd39cd PS4, Line 21: else if (CONFIG(PLATFORM_USES_FSP2_0)) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124091): https://review.coreboot.org/c/coreboot/+/56190/comment/abfd2685_d4362189 PS4, Line 21: else if (CONFIG(PLATFORM_USES_FSP2_0)) suspect code indent for conditional statements (5, 10)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124091): https://review.coreboot.org/c/coreboot/+/56190/comment/e8ff096d_1c61130b PS4, Line 22: return 72; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124091): https://review.coreboot.org/c/coreboot/+/56190/comment/32c9b945_00861d19 PS4, Line 22: return 72; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124091): https://review.coreboot.org/c/coreboot/+/56190/comment/fc7defb8_02a66a8c PS4, Line 23: else please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124091): https://review.coreboot.org/c/coreboot/+/56190/comment/2bc97e18_56a30624 PS4, Line 23: else suspect code indent for conditional statements (5, 10)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124091): https://review.coreboot.org/c/coreboot/+/56190/comment/cab4403b_b41cd06a PS4, Line 24: return dead_code_t(uint32_t); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124091): https://review.coreboot.org/c/coreboot/+/56190/comment/0f3fd411_99f4822d PS4, Line 24: return dead_code_t(uint32_t); please, no spaces at the start of a line