1 Feb
2020
1 Feb
'20
1:27 p.m.
Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33151 )
Change subject: mb/apple: Add MacBook Pro 8,1 support ......................................................................
Patch Set 13:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33151/13/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro8_1/gpio.c:
https://review.coreboot.org/c/coreboot/+/33151/13/src/mainboard/apple/macboo... PS13, Line 30: gpio9
This is OC5#, but it's used as a GPIO (SDCONN_STATE_CHANGE)
are you suggesting to change all this, or what?
--
To view, visit https://review.coreboot.org/c/coreboot/+/33151
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2
Gerrit-Change-Number: 33151
Gerrit-PatchSet: 13
Gerrit-Owner: Evgeny Zinoviev me@ch1p.io
Gerrit-Reviewer: Evgeny Zinoviev me@ch1p.io
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Patrick Rudolph siro@das-labor.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 01 Feb 2020 13:27:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment