[coreboot-gerrit] Change in coreboot[master]: src/soc/intel: Add support for CAR_HAS_SF_MASKS and select for TGL

[Shreesh Chhabbi (Code Review)]

Shreesh Chhabbi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48286 )

Change subject: src/soc/intel: Add support for CAR_HAS_SF_MASKS and select for TGL
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48286/5/src/soc/intel/common/block/... 
File src/soc/intel/common/block/cpu/car/cache_as_ram.S:

https://review.coreboot.org/c/coreboot/+/48286/5/src/soc/intel/common/block/... 
PS5, Line 426: dl
> What about the sequence I posted above? […]

Yes Tim. Thanks.
mov $0x01, %eax -> eax = 0x1
shl %cl, %eax -> cl = 0xc; eax = 0x1000
shl %cl, %eax  -> cl = 0xc; eax = 0x1000000
subl $0x01, %eax -> eax = 0xffffff