[coreboot-gerrit] Change in coreboot[master]: soc/intel/{cnl,icl}: Add provision to use PIRX PCI IRQ acpi package

[Aamir Bohra (Code Review)]

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34710 )

Change subject: soc/intel/{cnl,icl}: Add provision to use PIRX PCI IRQ acpi package
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34710/4/src/soc/intel/icelake/acpi/... 
File src/soc/intel/icelake/acpi/pci_irqs.asl:

https://review.coreboot.org/c/coreboot/+/34710/4/src/soc/intel/icelake/acpi/... 
PS4, Line 141: If (PICM) {
             : 		if (CondRefOf (PIRX)) {
             : 			Return (PIRX)
             : 		}
             : 		Return (^PICP)
             : 	} Else {
             : 		Return (^PICN)
             : 	}
> Why not always generate the ACPI table in SSDT and drop the static ones?

the dynamic generation is tied up with a Kconfig(in common driver CL in same patch train), if Kconfig is not selected , then need a fallback package. The idea was to allow a provision to on/off the feature if required.