Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45373 )
Change subject: soc/intel/common/block: Do not die if PRMRR size unsupported ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45373/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45373/1//COMMIT_MSG@10 PS1, Line 10: We don't do that when PRMRRs aren't even supported anyway.
I don't quite get the statement, tbh. We don't brick when it's […]
We only brick when the PRMRR *size* is unsupported. Let me try to explain the difference in a weird way:
PRMRR_Disabled : exception; PRMRRs_Not_Supported : exception; PRMRR_Size_Unsupported : exception;
-- [...]
exception when PRMRR_Size_Unsupported => Die; when others => return 0;
I could put this in the commit message, but I'd get weird looks 👀