Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38600 )
Change subject: i82371eb: Drop KB/Mouse/FDC declarations ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38600/2/src/southbridge/intel/i8237... File src/southbridge/intel/i82371eb/acpi/isabridge.asl:
https://review.coreboot.org/c/coreboot/+/38600/2/src/southbridge/intel/i8237... PS2, Line 83: }
It imports a common pnp declaration from superio/common
Did you test a PS/2 mouse? I find KBC definitions(?) in `src/superio/acpi/`, but not MOU and FDC0.
``` $ git grep MOU src/superio/ src/superio/common/ssdt.c: {ACPI_HID_MOUSE, {60, 64, }, {12, } }, src/superio/common/ssdt.c: {ACPI_HID_MOUSE, "PS2 Mouse"}, src/superio/ite/it8783ef/acpi/superio.asl: * 0x6 MOUSE Implemented, untested src/superio/ite/it8786e/acpi/superio.asl: * 0x6 MOUSE Implemented, untested $ git grep FDC0 src/superio/ src/superio/ite/it8772f/acpi/superio.asl:#ifdef SIO_ENABLE_FDC0 src/superio/ite/it8772f/acpi/superio.asl: Device (FDC0) // Floppy controller src/superio/smsc/sio1007/acpi/superio.asl:#ifdef SIO_ENABLE_FDC0 src/superio/smsc/sio1007/acpi/superio.asl: Device (FDC0) // Floppy controller src/superio/winbond/w83627hf/acpi/superio.asl: Device (FDC0) { src/superio/winbond/w83977tf/acpi/superio.asl:Device (FDC0) ```