Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45052 )
Change subject: soc/intel/tigerlake: Add Acoustic features
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45052/5/src/soc/intel/tigerlake/chi...
File src/soc/intel/tigerlake/chip.h:
https://review.coreboot.org/c/coreboot/+/45052/5/src/soc/intel/tigerlake/chi...
PS5, Line 153: /*
: * VR domains. The domains are IA,GT,SA,VLCC and FIVR.
: */
: enum {
: VR_DOMAIN_IA,
: VR_DOMAIN_GT,
: VR_DOMAIN_SA,
: VR_DOMAIN_VLCC,
: VR_DOMAIN_FIVR,
: VR_DOMAIN_MAX
: } vr_domains;
:
: /*
: * Slew Rate configuration for Deep Package C States for VR domain.
: * They are fast time divided by 2.
: * 0 - Fast/2
: * 1 - Fast/4
: * 2 - Fast/8
: * 3 - Fast/16
: */
: enum {
: SLEW_FAST_2,
: SLEW_FAST_4,
: SLEW_FAST_8,
: SLEW_FAST_16
: } slew_rate;
:
In addition to defining the enum values here, this also adds two (seemingly unused) fields called vr […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45052
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1924a3bac8beb16a9d841891696f9a3dea0d425f
Gerrit-Change-Number: 45052
Gerrit-PatchSet: 8
Gerrit-Owner: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Eric Herrmann
eherrmann@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 09 Oct 2020 17:38:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment