14 Jan
2019
14 Jan
'19
10:02 p.m.
Daniel Kurtz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30724 )
Change subject: drivers/generic/adau7002: Add wakeup-delay-ms property ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/30724/2/src/drivers/generic/adau7002/adau700... File src/drivers/generic/adau7002/adau7002.c:
https://review.coreboot.org/#/c/30724/2/src/drivers/generic/adau7002/adau700... PS2, Line 35: !dev->chip_info ADAU7002 is a common chip that is used in many configurations without this delay.
So, I think it is better if !dev->chip_info is not fatal, and instead just don't populate wakeup-delay-ms, or use a default value.
--
To view, visit https://review.coreboot.org/c/coreboot/+/30724
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I32b18bf80fad5899ab4093a127dfd52d589bc365
Gerrit-Change-Number: 30724
Gerrit-PatchSet: 2
Gerrit-Owner: Akshu Agrawal akshu.agrawal@amd.com
Gerrit-Reviewer: Akshu Agrawal akshu.agrawal@amd.com
Gerrit-Reviewer: Daniel Kurtz djkurtz@google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 14 Jan 2019 22:02:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment