Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41413 )
Change subject: Revert "device: Enable resource allocator to use multiple ranges" ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41413/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41413/1//COMMIT_MSG@14 PS1, Line 14:
Ack
Applying this patch and CB:41412 (but not CB:41412 alone) fixed an issue I had with master on Skylake and an Nvidia dGPU. CB:41363 did not fix it and adding CB:41418 and CB:41419 resulted in the platform not booting.
I can upload a full log if necessary, but the relevant parts, as I see it, are below.
"[ 0.339350] pci 0000:00:1c.0: can't claim BAR 15 [mem 0x80000000-0x91ffffff 64bit pref]: no compatible bridge window [ 0.339352] pci 0000:00:1c.0: [mem 0x80000000-0x91ffffff 64bit pref] clipped to [mem 0x80000001-0x91ffffff 64bit pref] [ 0.339354] pci 0000:00:1c.0: bridge window [mem 0x80000001-0x91ffffff 64bit pref] [ 0.339377] pci 0000:01:00.0: can't claim BAR 1 [mem 0x80000000-0x8fffffff 64bit pref]: no compatible bridge window
[...snip...]
[ 26.876926] NVRM: This PCI I/O region assigned to your NVIDIA device is invalid: NVRM: BAR1 is 0M @ 0x0 (PCI:0000:01:00.0) [ 26.876928] NVRM: The system BIOS may have misconfigured your GPU. [ 26.876933] nvidia: probe of 0000:01:00.0 failed with error -1 [ 26.876952] NVRM: The NVIDIA probe routine failed for 1 device(s). [ 26.876953] NVRM: None of the NVIDIA devices were initialized."