[coreboot-gerrit] Change in coreboot[master]: cpu/x86/smm: Add support for long mode

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35681 )

Change subject: cpu/x86/smm: Add support for long mode
......................................................................

Patch Set 11:

(3 comments)

https://review.coreboot.org/c/coreboot/+/35681/11//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/35681/11//COMMIT_MSG@21 
PS11, Line 21: Tested on Lenovo T410 with additional x86_64 patches.
This code does not use smm entry, so I don't think it makes much sense to mention here.

https://review.coreboot.org/c/coreboot/+/35681/11/src/cpu/x86/64bit/exit32.i... 
File src/cpu/x86/64bit/exit32.inc:

https://review.coreboot.org/c/coreboot/+/35681/11/src/cpu/x86/64bit/exit32.i... 
PS11, Line 42: jmp	__longmode_compatibility
any reason to not place that code here?

https://review.coreboot.org/c/coreboot/+/35681/11/src/cpu/x86/smm/smmhandler... 
File src/cpu/x86/smm/smmhandler.S:

https://review.coreboot.org/c/coreboot/+/35681/11/src/cpu/x86/smm/smmhandler... 
PS11, Line 215: #if defined(__x86_64__)
              : ia32efer_backup:
              : .long
              : #endif
You probably want to put this a different section like .bss?