Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31067 )
Change subject: mb/lenovo/x131e: function key support ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/#/c/31067/1/src/mainboard/lenovo/x131e/devicetre... File src/mainboard/lenovo/x131e/devicetree.cb:
https://review.coreboot.org/#/c/31067/1/src/mainboard/lenovo/x131e/devicetre... PS1, Line 118: event0 and event1 are critical on other lenovo devices, are they zero on x131e ?
https://review.coreboot.org/#/c/31067/1/src/mainboard/lenovo/x131e/romstage.... File src/mainboard/lenovo/x131e/romstage.c:
https://review.coreboot.org/#/c/31067/1/src/mainboard/lenovo/x131e/romstage.... PS1, Line 30: unrelated
https://review.coreboot.org/#/c/31067/1/src/mainboard/lenovo/x131e/smihandle... File src/mainboard/lenovo/x131e/smihandler.c:
https://review.coreboot.org/#/c/31067/1/src/mainboard/lenovo/x131e/smihandle... PS1, Line 81: //outb(0xe9, 0x64); // EC_KBD_CMD_MUTE don't include dead code