[coreboot-gerrit] Change in ...coreboot[master]: mb/lenovo/x131e: function key support

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. (
https://review.coreboot.org/c/coreboot/+/31067 )

Change subject: mb/lenovo/x131e: function key support
......................................................................


Patch Set 1:

(3 comments)

https://review.coreboot.org/#/c/31067/1/src/mainboard/lenovo/x131e/devicetr… 
File src/mainboard/lenovo/x131e/devicetree.cb:

https://review.coreboot.org/#/c/31067/1/src/mainboard/lenovo/x131e/devicetr… 
PS1, Line 118: 
event0 and event1 are critical on other lenovo devices, are they zero on x131e ?


https://review.coreboot.org/#/c/31067/1/src/mainboard/lenovo/x131e/romstage… 
File src/mainboard/lenovo/x131e/romstage.c:

https://review.coreboot.org/#/c/31067/1/src/mainboard/lenovo/x131e/romstage… 
PS1, Line 30: 
unrelated


https://review.coreboot.org/#/c/31067/1/src/mainboard/lenovo/x131e/smihandl… 
File src/mainboard/lenovo/x131e/smihandler.c:

https://review.coreboot.org/#/c/31067/1/src/mainboard/lenovo/x131e/smihandl… 
PS1, Line 81: 	//outb(0xe9, 0x64); // EC_KBD_CMD_MUTE
don't include dead code



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/31067
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib3a01f37a8b54889b55e92c501c9350e6c68bd57
Gerrit-Change-Number: 31067
Gerrit-PatchSet: 1
Gerrit-Owner: James Ye <jye836(a)gmail.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: James Ye <jye836(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Thu, 24 Jan 2019 14:22:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment