[coreboot-gerrit] Change in ...coreboot[master]: mediatek/mt8183: Enable RTC eosc calibration feature to save power

[Ran Bi (Code Review)]

Ran Bi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32339 )

Change subject: mediatek/mt8183: Enable RTC eosc calibration feature to save power
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/32339/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/32339/1//COMMIT_MSG@9 
PS1, Line 9: shutdown
> Is there a good reason why this is handled in coreboot/Arm TF respectively? Why can't you just do it […]

Patch in coreboot reason:
EOSC calibration only exist when system shutdown, we should not use EOSC clock directly without calibration. So we want to switch the clock to DCXO earlier because watchdog, BT and other modules might use this clock before kernel RTC init.

Patch in ATF reason:
We implement psci system_off function in ATF which contains some PMIC settings and RTC alarm settings. So we suppose it's better to put RTC eosc calibration setting here.