View Change
1 comment:
Commit Message:
Patch Set #1, Line 9: shutdown
Is there a good reason why this is handled in coreboot/Arm TF respectively? Why can't you just do it […]
Patch in coreboot reason:
EOSC calibration only exist when system shutdown, we should not use EOSC clock directly without calibration. So we want to switch the clock to DCXO earlier because watchdog, BT and other modules might use this clock before kernel RTC init.
Patch in ATF reason:
We implement psci system_off function in ATF which contains some PMIC settings and RTC alarm settings. So we suppose it's better to put RTC eosc calibration setting here.
To view, visit change 32339. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iee21e7611df8959cbbc63b6e6655cfb462147748
Gerrit-Change-Number: 32339
Gerrit-PatchSet: 2
Gerrit-Owner: Ran Bi <ran.bi@mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte@chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Ran Bi <ran.bi@mediatek.com>
Gerrit-Reviewer: Tristan Hsieh <tristan.shieh@mediatek.com>
Gerrit-Reviewer: You-Cheng Syu <youcheng@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Sun, 28 Apr 2019 07:08:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner <jwerner@chromium.org>
Comment-In-Reply-To: Ran Bi <ran.bi@mediatek.com>
Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-MessageType: comment