Attention is currently required from: Arthur Heymans, Maximilian Brune.
Philipp Hug has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80746?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/emulation/qemu-riscv: Change to -bios option
......................................................................
Patch Set 5: -Code-Review
(1 comment)
File src/mainboard/emulation/qemu-riscv/cbmem.c:
https://review.coreboot.org/c/coreboot/+/80746/comment/f4bfe921_3f4c6714 :
PS5, Line 10: return (uintptr_t)_dram + CONFIG_DRAM_SIZE_MB * MiB;
Can use probing here instead of hard-coding
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80746?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I009d97fa3e13068b91c604e987e50a65e525407d
Gerrit-Change-Number: 80746
Gerrit-PatchSet: 5
Gerrit-Owner: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Thu, 29 Feb 2024 17:35:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment