Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30987 )
Change subject: mb/asus: Add Asus A88XM-E FM2+ with documentation ......................................................................
Patch Set 38:
(4 comments)
https://review.coreboot.org/c/coreboot/+/30987/38/src/mainboard/asus/a88xm-e... File src/mainboard/asus/a88xm-e/Kconfig:
https://review.coreboot.org/c/coreboot/+/30987/38/src/mainboard/asus/a88xm-e... PS38, Line 39: default BOARD_ASUS_A88XM_E_DDR3_VOLT_150
Confirmed copy-paste ;) Which seems to work - for 1.50v RAM at least.
Why don't you try the other settings as well?
https://review.coreboot.org/c/coreboot/+/30987/38/src/mainboard/asus/a88xm-e... File src/mainboard/asus/a88xm-e/OemCustomize.c:
https://review.coreboot.org/c/coreboot/+/30987/38/src/mainboard/asus/a88xm-e... PS38, Line 104: * Untested: HDMI
This board has only one HDMI, which is working well by the way - tested. […]
Then this means something was copypasted without understanding what it does. Not resolved.
https://review.coreboot.org/c/coreboot/+/30987/38/src/mainboard/asus/a88xm-e... PS38, Line 171: if (CONFIG(BOARD_ASUS_A88XM_E)) Is this ever false?
https://review.coreboot.org/c/coreboot/+/30987/38/src/mainboard/asus/a88xm-e... File src/mainboard/asus/a88xm-e/bootblock.c:
https://review.coreboot.org/c/coreboot/+/30987/38/src/mainboard/asus/a88xm-e... PS38, Line 33: reg32 = CONFIG_BOARD_ASUS_A88XM_E_DDR3_VOLT_VAL;
If you are about this DigiVRM chip: on A88XM-E it is ASP1206 while i.e. […]
I wouldn't do such guesses.