Attention is currently required from: Raul Rangel, Martin Roth, Mathew King, EricR Lai.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52180 )
Change subject: mb/google/mancomb: add DXIO and DDI descriptors
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
i wonder if the missing pcie engine for lane 4 will result in running into the power management issue where the dummy descriptors were added as a workaround. maybe that's fixed when the prototype is ready, but it's probably something to keep in mind
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52180
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica4e6511a5106a958567565b96d5888b8c829ff2
Gerrit-Change-Number: 52180
Gerrit-PatchSet: 2
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Mathew King
mathewk@chromium.org
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Thu, 08 Apr 2021 22:03:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment