[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/braswell: add default option to use public FSP

[Frans Hendriks (Code Review)]

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32381 )

Change subject: soc/intel/braswell: add default option to use public FSP
......................................................................

Patch Set 2:

(1 comment)

This patch seems to be similar as https://review.coreboot.org/c/coreboot/+/29661
Would rebase the differences on that patch an alternative?

https://review.coreboot.org/#/c/32381/2/src/soc/intel/braswell/Makefile.inc 
File src/soc/intel/braswell/Makefile.inc:

https://review.coreboot.org/#/c/32381/2/src/soc/intel/braswell/Makefile.inc@... 
PS2, Line 59: CPPFLAGS_common += -I$(call strip_quotes,$(CONFIG_FSP_HEADER_PATH))
Did you also build and test after you removed the FspUpdVpd.h binary in vendorcode/../braswell?
I recall from my patch that the original (vendorcode) FspUpdVph.h was still used, which causes a hang during boot of the system.