Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48907 )
Change subject: mb/google/zork/var/vilboz: Fix Goodix touchscreen power sequence ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/48907/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48907/1//COMMIT_MSG@9 PS1, Line 9: update setting for the power sequence. Please be specific:
… increase the stop delay time from 100 ms to 160 ms.
https://review.coreboot.org/c/coreboot/+/48907/1//COMMIT_MSG@9 PS1, Line 9: spec Please note name and revision.
https://review.coreboot.org/c/coreboot/+/48907/1//COMMIT_MSG@10 PS1, Line 10: Does the touchscreen sometimes not work? Please add the problem description to the commit message.
https://review.coreboot.org/c/coreboot/+/48907/1//COMMIT_MSG@13 PS1, Line 13: TEST=measure the waveform is meet the Goodix touchscreen spec. Maybe:
Confirm the measured waveform complies with Goodix touchscreen spec.