Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46575 )
Change subject: mb/google/asurada: Add anx7625 panel driver
......................................................................
Patch Set 21:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46575/20/src/mainboard/google/asura...
File src/mainboard/google/asurada/panel.h:
https://review.coreboot.org/c/coreboot/+/46575/20/src/mainboard/google/asura...
PS20, Line 3: KUKUI_
ASURADA
Done
https://review.coreboot.org/c/coreboot/+/46575/20/src/mainboard/google/asura...
PS20, Line 32: #define INIT_DCS_CMD(...) \
: LCM_DCS_CMD, \
: sizeof((u8[]){__VA_ARGS__}), \
: __VA_ARGS__
:
: #define INIT_GENERIC_CMD(...) \
: LCM_GENERIC_CMD, \
: sizeof((u8[]){__VA_ARGS__}), \
: __VA_ARGS__
:
: #define INIT_DELAY_CMD(delay) \
: LCM_DELAY_CMD, \
: delay
:
: #define INIT_END_CMD \
: LCM_END_CMD
:
remove these because we don't have MIPI panel this time.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46575
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I045d2042b5649e36470500f266f108564b7063fa
Gerrit-Change-Number: 46575
Gerrit-PatchSet: 21
Gerrit-Owner: yongqiang niu
yongqiang.niu@mediatek.com
Gerrit-Reviewer: CK HU
ck.hu@mediatek.com
Gerrit-Reviewer: Huijuan Xie
huijuan.xie@mediatek.corp-partner.google.com
Gerrit-Reviewer: Jg Daolongzhu
jg_daolongzhu@mediatek.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Yidi Lin
yidi.lin@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Thu, 10 Dec 2020 08:51:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment