Attention is currently required from: Martin L Roth.
Felix Held has posted comments on this change by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/75495?usp=email )
Change subject: Documentation: Write down coreboot's git commit message rules
......................................................................
Patch Set 5:
(1 comment)
File Documentation/contributing/git_commit_messages.md:
https://review.coreboot.org/c/coreboot/+/75495/comment/30addca6_2e2b5f02?usp... :
PS5, Line 16: 75
this should all be 72, right? not sure where the 75 is from, but i'm quite sure that that one isn't correct
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75495?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic2ba681193e302318934cc2f7f30659eac73d099
Gerrit-Change-Number: 75495
Gerrit-PatchSet: 5
Gerrit-Owner: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Jan Samek
samekh@email.cz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Himanshu Sahdev
himanshu.sahdev@intel.com
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-CC: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Comment-Date: Mon, 07 Apr 2025 12:50:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No