Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42637 )
Change subject: sb/intel/i82801jx: Move `acpi_fill_fadt` to fadt.c
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42637/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42637/1//COMMIT_MSG@9
PS1, Line 9: At least i82801ix does this.
I have just added that file with commit 64e07eb.
I think we should do a treewide decision whether the separate fadt.c makes sense and coordinate with CB:40036.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42637
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic555ab17c2eca0399938d2842ca51628899c1544
Gerrit-Change-Number: 42637
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 21 Jun 2020 12:48:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment