Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46351 )
Change subject: soc/intel/broadwell/lpc.c: Drop reg-script usage for PCH misc init
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46351/4/src/soc/intel/broadwell/lpc...
File src/soc/intel/broadwell/lpc.c:
https://review.coreboot.org/c/coreboot/+/46351/4/src/soc/intel/broadwell/lpc...
PS4, Line 218: RCBA32_AND_OR(0x3f02, ~0xf, 0);
This is not a good idea. […]
Nak
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46351
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4846f9303367452bbb1d21c2d7f4a1fb9f2efe5d
Gerrit-Change-Number: 46351
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 14 Oct 2020 08:28:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment