Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41792 )
Change subject: acpi: Add support for writing UART device descriptors
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41792/3/src/include/acpi/acpi_devic...
File src/include/acpi/acpi_device.h:
https://review.coreboot.org/c/coreboot/+/41792/3/src/include/acpi/acpi_devic...
PS3, Line 427: bytes per second
Isn't this bits-per-second as per Table 6-243? (Spec 6.3)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41792
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I671ce2a499d74717d8677528c46ab3fbc1d7faf5
Gerrit-Change-Number: 41792
Gerrit-PatchSet: 3
Gerrit-Owner: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Thu, 04 Jun 2020 03:44:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment