Attention is currently required from: Nico Huber, Maximilian Brune, Arthur Heymans.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68160 )
Change subject: util/cbfstool: Add a new mechanism to provide a memory mapped ......................................................................
Patch Set 4: Code-Review+2
(2 comments)
File src/soc/intel/common/block/fast_spi/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/68160/comment/3a87bcd4_69782ff8 PS4, Line 91: FLASH_BIOS_BASE nit: I find the naming here a bit confusing, it took me too long to figure out that "BIOS" and "EXT_BIOS" are the two things you're distinguishing. Maybe if you also defined MMIO_BIOS_BASE, BIOS_SIZE and FLASH_EXT_BIOS_BASE (even though they're trivial) it would be a bit clearer? Or maybe a different naming scheme like DEFAULT_WINDOW_FLASH_BASE, EXTENDED_WINDOW_MMIO_BASE, EXTENDED_WINDOW_SIZE would be easier to follow.
https://review.coreboot.org/c/coreboot/+/68160/comment/17a9f5ea_f4f0aece PS4, Line 93: $(call int-subtract, $(CONFIG_ROM_SIZE) 0x1000000)) EXT_BIOS_SIZE