Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40424 )
Change subject: ec/google/chromeec: Add support for USB Type-C alternate mode control
......................................................................
Patch Set 1:
(1 comment)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/40424/1/src/ec/google/chromeec/acpi...
File src/ec/google/chromeec/acpi/cros_ec.asl:
https://review.coreboot.org/c/coreboot/+/40424/1/src/ec/google/chromeec/acpi...
PS1, Line 60: Device (USBC)
Yes, the plan is to generate this stuff at runtime. In fact, https://review.coreboot. […]
I'd be happy to take a look once we have an idea what the generated ASL should look like.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40424
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8c872537d9c633f8eb4238fd9b023577c4570a5a
Gerrit-Change-Number: 40424
Gerrit-PatchSet: 1
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Thu, 16 Apr 2020 15:54:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment