Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30989 )
Change subject: intelblocks/systemagent: Add ACPI table generation hook ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/#/c/30989/6/src/soc/intel/common/block/include/i... File src/soc/intel/common/block/include/intelblocks/acpi.h:
https://review.coreboot.org/#/c/30989/6/src/soc/intel/common/block/include/i... PS6, Line 5: * Copyright (C) 2019 Siemens AG NB. I don't see how this change affects copyright. Also, even if, I think this would have to be written as `2017, 2019` as the additions from 2017 haven't been removed.
https://review.coreboot.org/#/c/30989/6/src/soc/intel/common/block/systemage... File src/soc/intel/common/block/systemagent/systemagent.c:
https://review.coreboot.org/#/c/30989/6/src/soc/intel/common/block/systemage... PS6, Line 58: } NB. with all these weak function, I wonder why the driver is defined here instead of the SoC level. Drivers at the SoC level could still directly point to common/ functions, so this indirection here seems unnecessary.