Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46676 )
Change subject: mb/google/volteer/variants/delbin: Update DPTF parameters for delbin
......................................................................
Patch Set 13:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46676/12/src/mainboard/google/volte...
File src/mainboard/google/volteer/variants/delbin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46676/12/src/mainboard/google/volte...
PS12, Line 31: TEMP_PCT(57, 90),
: TEMP_PCT(47, 80),
: TEMP_PCT(40, 70),
: TEMP_PCT(36, 60),
: TEMP_PCT(34, 50),
: TEMP_PCT(30, 40),}}}"
Hi Tim, sensor 3 is the ambient sensor near the fan. […]
Ack
https://review.coreboot.org/c/coreboot/+/46676/12/src/mainboard/google/volte...
PS12, Line 74:
Good catch :) I have added it for now. […]
If you are not changing this table from the baseboard, you can leave it out here and it will pick up the baseboard default (variants/baseboard/devicetree.cb)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46676
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I69aa6046fdc90a2cf59ea3a13fdb15c8bc0d29a2
Gerrit-Change-Number: 46676
Gerrit-PatchSet: 13
Gerrit-Owner: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Deepika Punyamurtula
deepika.punyamurtula@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Todd Broch
tbroch@google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hank Lin
hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-CC: Zhuohao Lee
zhuohao@google.com
Gerrit-Comment-Date: Thu, 29 Oct 2020 18:49:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Deepika Punyamurtula
deepika.punyamurtula@intel.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment