[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: Program HD Audio SVID/SSID

[Lijian Zhao (Code Review)]

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29651 )

Change subject: soc/intel/cannonlake: Program HD Audio SVID/SSID
......................................................................

Patch Set 5:
> Is this just setting subsystem ids of a PCI device? These should be
> set in the devicetree and no blob needed.
>
> If yes, this seems backwards. Shouldn't we set the id of the PCI
> device first and when configuring the codec take the id of the PCI
> device?

From https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/sound/..., I can see the codec driver is comparing ssid in codec and pci bus ssid. Since the codec SSID is fixed with sku, then I believe we can only change pci ssid to match with that.

Why we need to go through FSP but not in device tree had been discussed in 29490.