Attention is currently required from: Tim Wawrzynczak, Rizwan Qureshi, Angel Pons. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48344 )
Change subject: soc/intel/common/block/cpu: Introduce CAR_HAS_YMM Kconfig ......................................................................
Patch Set 9:
(8 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/48344/comment/ad669aca_6e4008e2 PS9, Line 11: 2. Select CAR_HAS_SF_MASKS : 3. Select COS_MAPPED_TO_MSB
where is this?
Ack
https://review.coreboot.org/c/coreboot/+/48344/comment/04fad95d_1a7273c7 PS9, Line 28: proofs
proves
OMG ðŸ˜
File src/soc/intel/common/block/cpu/Kconfig:
https://review.coreboot.org/c/coreboot/+/48344/comment/261a0457_78eae7e9 PS9, Line 73: CAR_HAS_YMM
suggestion: […]
Ack
https://review.coreboot.org/c/coreboot/+/48344/comment/46d35b9b_abe33bf6 PS9, Line 80: SF
snoop filter
Ack
File src/soc/intel/common/block/cpu/car/cache_as_ram.S:
https://review.coreboot.org/c/coreboot/+/48344/comment/3009f166_5af53c41 PS9, Line 542: #if CONFIG(CAR_HAS_YMM)
This code also uses rdmsr/wrmsr and so has to use `ecx`, therefore its value must be saved first. […]
Ack
https://review.coreboot.org/c/coreboot/+/48344/comment/e09217b9_c60d1e5c PS9, Line 543: /* Set MSR 0x1892 IA32_CR_SF_QOS_MASK_2 = (2^(no, of data ways) - 1) */
can you also add a clarification that this value is also the non-eviction mask?
Ack
https://review.coreboot.org/c/coreboot/+/48344/comment/898dc14e_5bf98705 PS9, Line 550: mov %ebx, %eax : xorl %edx, %edx
IIUC, these registers should still contain these values (I don't think wrmsr should have changed the […]
Ack
File src/soc/intel/common/block/cpu/car/exit_car.S:
https://review.coreboot.org/c/coreboot/+/48344/comment/27740a17_022c3ad2 PS9, Line 102: mov $0x00000, %eax
`xorl %eax, %eax`
Ack