Attention is currently required from: Tim Wawrzynczak, Rizwan Qureshi, Angel Pons.
8 comments:
Commit Message:
2. Select CAR_HAS_SF_MASKS
3. Select COS_MAPPED_TO_MSB
where is this?
Ack
Patch Set #9, Line 28: proofs
proves
OMG ðŸ˜
File src/soc/intel/common/block/cpu/Kconfig:
Patch Set #9, Line 73: CAR_HAS_YMM
suggestion: […]
Ack
snoop filter
Ack
File src/soc/intel/common/block/cpu/car/cache_as_ram.S:
Patch Set #9, Line 542: #if CONFIG(CAR_HAS_YMM)
This code also uses rdmsr/wrmsr and so has to use `ecx`, therefore its value must be saved first. […]
Ack
Patch Set #9, Line 543: /* Set MSR 0x1892 IA32_CR_SF_QOS_MASK_2 = (2^(no, of data ways) - 1) */
can you also add a clarification that this value is also the non-eviction mask?
Ack
mov %ebx, %eax
xorl %edx, %edx
IIUC, these registers should still contain these values (I don't think wrmsr should have changed the […]
Ack
File src/soc/intel/common/block/cpu/car/exit_car.S:
Patch Set #9, Line 102: mov $0x00000, %eax
`xorl %eax, %eax`
Ack
To view, visit change 48344. To unsubscribe, or for help writing mail filters, visit settings.