Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48766 )
Change subject: sb/intel/ibexpeak: Drop ChromeOS setup for GNVS
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48766/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/48766/1//COMMIT_MSG@9
PS1, Line 9: copy-paste
: and fork
nit: copy-paste*d* and fork*ed*
Done
https://review.coreboot.org/c/coreboot/+/48766/1/src/southbridge/intel/ibexp...
File src/southbridge/intel/ibexpeak/acpi/globalnvs.asl:
https://review.coreboot.org/c/coreboot/+/48766/1/src/southbridge/intel/ibexp...
PS1, Line 113: S3UE
Sounds like a followup if someone cares.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48766
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I16406516b51c13d49593bc8a3e1e5b868eea6f24
Gerrit-Change-Number: 48766
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 22 Dec 2020 17:22:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Gerrit-MessageType: comment