Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34751 )
Change subject: arch/x86: Add new API for run_ramstage_phase()
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34751/7/src/arch/x86/postcar_loader...
File src/arch/x86/postcar_loader.c:
https://review.coreboot.org/c/coreboot/+/34751/7/src/arch/x86/postcar_loader...
PS7, Line 229: die("RELOCATABLE_RAMSTAGE must be selected!");
You could turn this into an #error as well instead of a runtime die(). I was thinking static assert would work -- but only if things are properly guarded. At that point #error is what we want.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34751
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d2200d95e68c0eb01681b8f9b71b3d30d122c43
Gerrit-Change-Number: 34751
Gerrit-PatchSet: 7
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 12 Aug 2019 15:14:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment